Remake Twitter handle saving with Vue and modularize account property components #33217

Pytal · 2022-07-13T00:27:56Z

Remake Twitter handle saving with Vue for accessibility purposes alongside preparations for allowing simple replacement of other account property sections with Vue

Incorporates improvements to accessibility from the https://github.com/nextcloud/nextcloud-vue library over the legacy PHP implementation

Deprecation

The lookupServerUploadEnabled block

server/apps/settings/templates/settings/personal/personal.info.php

Lines 208 to 235 in 16b06dd

    
           <?php if ($_['lookupServerUploadEnabled']) { ?> 
        
           	<div class="verify <?php if ($_['twitter'] === '' || $_['twitterScope'] !== 'public') { 
        
           		p('hidden'); 
        
           	} ?>"> 
        
           		<img id="verify-twitter" title="<?php p($_['twitterMessage']); ?>" data-status="<?php p($_['twitterVerification']) ?>" src=" 
        
           	<?php 
        
           	switch ($_['twitterVerification']) { 
        
           		case \OC\Accounts\AccountManager::VERIFICATION_IN_PROGRESS: 
        
           			p(image_path('core', 'actions/verifying.svg')); 
        
           			break; 
        
           		case \OC\Accounts\AccountManager::VERIFIED: 
        
           			p(image_path('core', 'actions/verified.svg')); 
        
           			break; 
        
           		default: 
        
           			p(image_path('core', 'actions/verify.svg')); 
        
           	} 
        
           	?>" <?php if ($_['twitterVerification'] === \OC\Accounts\AccountManager::VERIFICATION_IN_PROGRESS || $_['twitterVerification'] === \OC\Accounts\AccountManager::NOT_VERIFIED) { 
        
           		print_unescaped(' class="verify-action"'); 
        
           	} ?>> 
        
           		<div class="verification-dialog popovermenu bubble menu"> 
        
           			<div class="verification-dialog-content"> 
        
           				<p class="explainVerification"></p> 
        
           				<p class="verificationCode"></p> 
        
           				<p><?php p($l->t('It can take up to 24 hours before the account is displayed as verified.')); ?></p> 
        
           			</div> 
        
           		</div> 
        
           	</div> 
        
           <?php } ?>

is deprecated and therefore not brought over as it is only displayed under the condition that your Twitter handle is set and the scope is public which is never the case as the public scope was deprecated in 21.0.1

server/lib/public/Accounts/IAccountManager.php

Lines 86 to 91 in 16b06dd

    
           	/** 
        
           	 * Contact details visible on trusted federated servers and in the public lookup server. 
        
           	 * 
        
           	 * @deprecated 21.0.1 
        
           	 */ 
        
           	public const VISIBILITY_PUBLIC = 'public';

Requires

Consolidate account property getters #33206

apps/settings/src/components/PersonalInfo/TwitterSection/TwitterSection.vue

Pytal · 2022-07-15T20:33:14Z

Keeping as draft pending merge of

Consolidate account property getters #33206

artonge

Nice cleanup :)

apps/settings/src/components/PersonalInfo/shared/AccountPropertyInput.vue

apps/settings/src/components/PersonalInfo/shared/AccountPropertySection.vue

Pytal · 2022-08-09T03:11:36Z

Rebased and review-ready

PVince81 · 2022-08-10T20:49:13Z

@Pytal this PR seems to contain a lot more changes than just the Twitter handle, in case it's not a mistake, please adjust the PR title and description

Pytal · 2022-08-11T01:27:49Z

@Pytal this PR seems to contain a lot more changes than just the Twitter handle, in case it's not a mistake, please adjust the PR title and description

Title updated, description already adjusted and commits already split between modularization and Twitter section

PVince81 · 2022-08-25T15:21:26Z

@Pytal rebase needed and also a second review

Signed-off-by: Christopher Ng <[email protected]>

PVince81

👍

Pytal added enhancement 2. developing Work in progress feature: settings labels Jul 13, 2022

Pytal added this to the Nextcloud 25 milestone Jul 13, 2022

Pytal self-assigned this Jul 13, 2022

Pytal mentioned this pull request Jul 13, 2022

Personal Info Settings Vuetified [Meta] #27869

Closed

11 tasks

tcitworld reviewed Jul 13, 2022

View reviewed changes

apps/settings/src/components/PersonalInfo/TwitterSection/TwitterSection.vue Outdated Show resolved Hide resolved

Pytal force-pushed the enh/27869/twitter branch from 76b54fb to b995f76 Compare July 14, 2022 01:15

This comment was marked as outdated.

Sign in to view

Pytal force-pushed the enh/27869/consolidate branch from 64584ef to a70eb01 Compare July 15, 2022 03:32

Pytal force-pushed the enh/27869/twitter branch 2 times, most recently from 0219f8b to a556c67 Compare July 15, 2022 04:30

Pytal force-pushed the enh/27869/consolidate branch from a70eb01 to ae18cdd Compare July 15, 2022 19:15

Pytal force-pushed the enh/27869/twitter branch 3 times, most recently from 1bb7323 to f644707 Compare July 15, 2022 20:22

Pytal added 3. to review Waiting for reviews feature: accessibility and removed 2. developing Work in progress labels Jul 15, 2022

Pytal force-pushed the enh/27869/twitter branch 2 times, most recently from 4dbe41e to 6cf836a Compare July 15, 2022 20:50

This comment was marked as outdated.

Sign in to view

Pytal force-pushed the enh/27869/twitter branch from 6cf836a to 446b83f Compare July 19, 2022 00:34

Pytal mentioned this pull request Jul 20, 2022

Remake location property saving with Vue #33285

Merged

1 task

Pytal force-pushed the enh/27869/consolidate branch from ae18cdd to 3430808 Compare July 21, 2022 01:14

Pytal force-pushed the enh/27869/twitter branch 2 times, most recently from edbce9e to 77f73f8 Compare July 26, 2022 00:51

This comment was marked as outdated.

Sign in to view

Base automatically changed from enh/27869/consolidate to master July 26, 2022 07:13

Pytal requested review from artonge and marcoambrosini July 27, 2022 00:22

Pytal force-pushed the enh/27869/twitter branch from 13ca063 to 91fc449 Compare July 27, 2022 00:53

artonge requested changes Jul 28, 2022

View reviewed changes

apps/settings/src/components/PersonalInfo/shared/AccountPropertyInput.vue Outdated Show resolved Hide resolved

apps/settings/src/components/PersonalInfo/shared/AccountPropertySection.vue Outdated Show resolved Hide resolved

Pytal force-pushed the enh/27869/twitter branch from 91fc449 to c6361da Compare July 29, 2022 00:13

Pytal requested a review from artonge July 29, 2022 00:14

Pytal force-pushed the enh/27869/twitter branch 2 times, most recently from 5e6458f to db89be3 Compare July 29, 2022 00:40

artonge approved these changes Jul 29, 2022

View reviewed changes

Pytal force-pushed the enh/27869/twitter branch 3 times, most recently from 7e0cd45 to 7fd6634 Compare July 29, 2022 20:16

Pytal force-pushed the enh/27869/twitter branch from 7fd6634 to df757f3 Compare August 9, 2022 03:09

Pytal changed the title ~~Remake Twitter handle saving with Vue~~ Remake Twitter handle saving with Vue and modularize account property components Aug 11, 2022

Pytal force-pushed the enh/27869/twitter branch from df757f3 to 257ab46 Compare August 11, 2022 02:12

This was referenced Aug 12, 2022

25.0.0 beta 1 #33505

Merged

25.0.0 beta 2 #33592

Merged

blizzz mentioned this pull request Aug 24, 2022

25.0.0 beta 3 #33674

Merged

Pytal added 2 commits August 25, 2022 18:08

Modularize shared account property components

c5c70da

Signed-off-by: Christopher Ng <[email protected]>

Remake Twitter handle saving with Vue

09f6eb5

Signed-off-by: Christopher Ng <[email protected]>

Pytal force-pushed the enh/27869/twitter branch from 257ab46 to 09f6eb5 Compare August 25, 2022 18:19

PVince81 approved these changes Aug 25, 2022

View reviewed changes

PVince81 merged commit 38d0419 into master Aug 25, 2022

delete-merged-branch bot deleted the enh/27869/twitter branch August 25, 2022 21:40

PVince81 mentioned this pull request Aug 25, 2022

Fix various accessibility issues #33259

Merged

blizzz mentioned this pull request Aug 30, 2022

25.0.0 beta 4 #33762

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remake Twitter handle saving with Vue and modularize account property components #33217

Remake Twitter handle saving with Vue and modularize account property components #33217

Pytal commented Jul 13, 2022 •

edited

Loading

This comment was marked as outdated.

Pytal commented Jul 15, 2022 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

artonge left a comment

Pytal commented Aug 9, 2022

PVince81 commented Aug 10, 2022

Pytal commented Aug 11, 2022

PVince81 commented Aug 25, 2022

PVince81 left a comment

	<?php if ($_['lookupServerUploadEnabled']) { ?>
	<div class="verify <?php if ($_['twitter'] === '' \|\| $_['twitterScope'] !== 'public') {
	p('hidden');
	} ?>">
	<img id="verify-twitter" title="<?php p($_['twitterMessage']); ?>" data-status="<?php p($_['twitterVerification']) ?>" src="
	<?php
	switch ($_['twitterVerification']) {
	case \OC\Accounts\AccountManager::VERIFICATION_IN_PROGRESS:
	p(image_path('core', 'actions/verifying.svg'));
	break;
	case \OC\Accounts\AccountManager::VERIFIED:
	p(image_path('core', 'actions/verified.svg'));
	break;
	default:
	p(image_path('core', 'actions/verify.svg'));
	}
	?>" <?php if ($_['twitterVerification'] === \OC\Accounts\AccountManager::VERIFICATION_IN_PROGRESS \|\| $_['twitterVerification'] === \OC\Accounts\AccountManager::NOT_VERIFIED) {
	print_unescaped(' class="verify-action"');
	} ?>>
	<div class="verification-dialog popovermenu bubble menu">
	<div class="verification-dialog-content">
	<p class="explainVerification"></p>
	<p class="verificationCode"></p>
	<p><?php p($l->t('It can take up to 24 hours before the account is displayed as verified.')); ?></p>
	</div>
	</div>
	</div>
	<?php } ?>

	/**
	* Contact details visible on trusted federated servers and in the public lookup server.
	*
	* @deprecated 21.0.1
	*/
	public const VISIBILITY_PUBLIC = 'public';

Remake Twitter handle saving with Vue and modularize account property components #33217

Remake Twitter handle saving with Vue and modularize account property components #33217

Conversation

Pytal commented Jul 13, 2022 • edited Loading

Requires

This comment was marked as outdated.

Pytal commented Jul 15, 2022 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

artonge left a comment

Choose a reason for hiding this comment

Pytal commented Aug 9, 2022

PVince81 commented Aug 10, 2022

Pytal commented Aug 11, 2022

PVince81 commented Aug 25, 2022

PVince81 left a comment

Choose a reason for hiding this comment

Pytal commented Jul 13, 2022 •

edited

Loading

Pytal commented Jul 15, 2022 •

edited

Loading